[NSJ -> STJ]Add STJ converters for PackageSearchMetadata deserialization#7301
Open
Nigusu-Allehu wants to merge 2 commits intodevfrom
Open
[NSJ -> STJ]Add STJ converters for PackageSearchMetadata deserialization#7301Nigusu-Allehu wants to merge 2 commits intodevfrom
PackageSearchMetadata deserialization#7301Nigusu-Allehu wants to merge 2 commits intodevfrom
Conversation
Nigusu-Allehu
changed the title
PackageSearchMetadata deserialization
Nigusu-Allehu
force-pushed
the
dev-nyenework-stj-converters
branch
2 times, most recently
from
a8c5440 to
da467a2
Compare
Nigusu-Allehu
changed the base branch from
dev-feature-nsj-stj-migration
to
dev
Nigusu-Allehu
force-pushed
the
dev-nyenework-stj-converters
branch
from
86f1223 to
48827e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Related: NuGet/Home#14846
Description
Part of the NSJ to STJ migration. Adds 9 System.Text.Json converters equivalent to their Newtonsoft.Json counterparts:
SafeBoolStjConverterSafeBoolConverterSafeUriStjConverterSafeUriConverterNuGetVersionStjConverterNuGetVersionConverterNuGetFrameworkStjConverterNuGetFrameworkConverterMetadataFieldStjConverterMetadataFieldConverterMetadataStringOrArrayStjConverterMetadataStringOrArrayConverterVersionInfoStjConverterVersionInfoConverterPackageDependencyStjConverter[JsonConstructor]onPackageDependency)PackageDependencyGroupStjConverter[JsonConstructor]onPackageDependencyGroup)Converters that are deserialization-only (matching NSJ
CanWrite = false) haveWritethrowNotSupportedException.PackageDependencyandPackageDependencyGroupuse dedicated converters instead of[JsonConstructor]to avoid exposing a new public constructor onPackageDependencyGroupand movingVersionRangeStjConverterintoNuGet.Packaging— both changes that exist solely to serve Protocol's deserialization needs.PR Checklist